netdev - Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Jan 2021 20:41:51 -0600
From:   Rob Herring <robh@...nel.org>
To:     Alex Elder <elder@...aro.org>
Cc:     davem@...emloft.net, kuba@...nel.org, evgreen@...omium.org,
        bjorn.andersson@...aro.org, cpratapa@...eaurora.org,
        subashab@...eaurora.org, rdunlap@...radead.org,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc
 property

On Tue, Jan 12, 2021 at 01:28:29PM -0600, Alex Elder wrote:
> The IPA driver uses the remoteproc SSR notifier now, rather than the
> temporary IPA notification system used initially.  As a result it no
> longer needs a property identifying the modem subsystem DT node.
> 
> Use GIC_SPI rather than 0 in the example interrupt definition.
> 
> Signed-off-by: Alex Elder <elder@...aro.org>
> ---
>  Documentation/devicetree/bindings/net/qcom,ipa.yaml | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 8a2d12644675b..a8cff214ee11f 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -113,13 +113,6 @@ properties:
>        performing early IPA initialization, including loading and
>        validating firwmare used by the GSI.
>  
> -  modem-remoteproc:
> -    $ref: /schemas/types.yaml#/definitions/phandle
> -    description:
> -      This defines the phandle to the remoteproc node representing
> -      the modem subsystem.  This is requied so the IPA driver can
> -      receive and act on notifications of modem up/down events.
> -
>    memory-region:
>      maxItems: 1
>      description:
> @@ -135,7 +128,6 @@ required:
>    - interrupts
>    - interconnects
>    - qcom,smem-states
> -  - modem-remoteproc
>  
>  oneOf:
>    - required:
> @@ -168,7 +160,6 @@ examples:
>                  compatible = "qcom,sdm845-ipa";
>  
>                  modem-init;
> -                modem-remoteproc = <&mss_pil>;
>  
>                  iommus = <&apps_smmu 0x720 0x3>;
>                  reg = <0x1e40000 0x7000>,
> @@ -178,8 +169,8 @@ examples:
>                              "ipa-shared",
>                              "gsi";
>  
> -                interrupts-extended = <&intc 0 311 IRQ_TYPE_EDGE_RISING>,
> -                                      <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>,
> +                interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>,
> +                                      <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,

You need the include file.

>                                        <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
>                                        <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
>                  interrupt-names = "ipa",
> -- 
> 2.20.1
>