netdev - Re: [PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114085308.7cda4d92@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 14 Jan 2021 08:53:08 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pengcheng Yang <yangpc@...gsu.com>
Cc:     edumazet@...gle.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw_isn not being used

On Tue, 29 Dec 2020 05:59:20 +0800 Pengcheng Yang wrote:
> TCP_SKB_CB(skb)->tcp_tw_isn contains an ISN, chosen by
> tcp_timewait_state_process() , when SYN is received in TIMEWAIT state.
> But tcp_tw_isn is not used because it is overwritten by
> tcp_v4_restore_cb() after commit eeea10b83a13 ("tcp: add
> tcp_v4_fill_cb()/tcp_v4_restore_cb()").
> 
> To fix this case, we record tcp_tw_isn before tcp_v4_restore_cb() and
> then set it in tcp_v4_fill_cb(). V6 does the same.
> 
> Fixes: eeea10b83a13 ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()")
> Reported-by: chenc <chenc9@...gsu.com>
> Signed-off-by: Pengcheng Yang <yangpc@...gsu.com>

Please fix the date and resend. This patch came in last night, 
but it has a date of December 28th.