netdev - Re: [1/2] iwlwifi: dbg: Don't touch the tlv data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210114165704.F3E95C43461@smtp.codeaurora.org>
Date:   Thu, 14 Jan 2021 16:57:04 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Luca Coelho <luciano.coelho@...el.com>
Subject: Re: [1/2] iwlwifi: dbg: Don't touch the tlv data

Takashi Iwai <tiwai@...e.de> wrote:

> The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device
> memory") added a termination of name string just to be sure, and this
> seems causing a regression, a GPF triggered at firmware loading.
> Basically we shouldn't modify the firmware data that may be provided
> as read-only.
> 
> This patch drops the code that caused the regression and keep the tlv
> data as is.
> 
> Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")
> BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733
> Cc: stable@...r.kernel.org
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> Acked-by: Luca Coelho <luciano.coelho@...el.com>

Patch applied to wireless-drivers.git, thanks.

a6616bc9a0af iwlwifi: dbg: Don't touch the tlv data

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210112132449.22243-2-tiwai@suse.de/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches