netdev - Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1l9nls-0049Tk-1p@farmhouse.coelho.fi>
Date:   Wed, 10 Feb 2021 13:35:00 +0200
From:   Luca Coelho <luca@...lho.fi>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Luca Coelho <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

Takashi Iwai <tiwai@...e.de> wrote:

> The ucode TLV data may be read-only and should be treated as const
> pointers, but currently a few code forcibly cast to the writable
> pointer unnecessarily.  This gave developers a wrong impression as if
> it can be modified, resulting in crashing regressions already a couple
> of times.
> 
> This patch adds the const prefix to those cast pointers, so that such
> attempt can be caught more easily in future.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> Acked-by: Luca Coelho <luciano.coelho@...el.com>

Patch applied to iwlwifi-next.git, thanks.

71b6254a6c98 iwlwifi: dbg: Mark ucode tlv data as const