netdev - Re: [net-next V6 02/14] devlink: Introduce PCI SF port flavour and port attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114102229.3ac56a1c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 14 Jan 2021 10:22:29 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Parav Pandit <parav@...dia.com>
Cc:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jason Gunthorpe <jgg@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Leon Romanovsky <leonro@...dia.com>,
        Jiri Pirko <jiri@...dia.com>, Vu Pham <vuhuong@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net-next V6 02/14] devlink: Introduce PCI SF port flavour and
 port attribute

On Thu, 14 Jan 2021 17:53:09 +0000 Parav Pandit wrote:
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Thursday, January 14, 2021 11:13 PM
> > 
> > On Wed, 13 Jan 2021 11:27:18 -0800 Saeed Mahameed wrote:  
> > >  /**
> > >   * struct devlink_port_attrs - devlink port object
> > >   * @flavour: flavour of the port
> > > @@ -114,6 +126,7 @@ struct devlink_port_attrs {
> > >  		struct devlink_port_phys_attrs phys;
> > >  		struct devlink_port_pci_pf_attrs pci_pf;
> > >  		struct devlink_port_pci_vf_attrs pci_vf;
> > > +		struct devlink_port_pci_sf_attrs pci_sf;
> > >  	};
> > >  };  
> > 
> > include/net/devlink.h:131: warning: Function parameter or member 'pci_sf'
> > not described in 'devlink_port_attrs'  
> Wasn't reported till v5.
> Can you please share, which script catches this? So that I can run next time early.

This is just scripts/kernel-doc from the tree.

All the tests are here:

https://github.com/kuba-moo/nipa/blob/master/tests/