netdev - Re: [PATCH net] net: sit: unregister_netdevice on newlink's error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210114102736.037c6494@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 14 Jan 2021 10:27:36 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        syzbot+2393580080a2da190f04@...kaller.appspotmail.com
Subject: Re: [PATCH net] net: sit: unregister_netdevice on newlink's error
 path

On Thu, 14 Jan 2021 09:49:48 +0100 Nicolas Dichtel wrote:
> Le 14/01/2021 à 02:29, Jakub Kicinski a écrit :
> [snip]
> > --- a/net/ipv6/sit.c
> > +++ b/net/ipv6/sit.c
> > @@ -1645,8 +1645,11 @@ static int ipip6_newlink(struct net *src_net, struct net_device *dev,
> >  	}
> >  
> >  #ifdef CONFIG_IPV6_SIT_6RD
> > -	if (ipip6_netlink_6rd_parms(data, &ip6rd))
> > +	if (ipip6_netlink_6rd_parms(data, &ip6rd)) {
> >  		err = ipip6_tunnel_update_6rd(nt, &ip6rd);
> > +		if (err)  
> nit: I would prefer 'if (err < 0)' to be consistent with the rest of the sit
> code, but it's purely aesthetic (ipip6_tunnel_update_6rd() returns a negative
> value or 0).

Done.

> With or without this:
> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Thanks for the review, applied!