netdev - Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jan 2021 22:02:36 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Giacinto Cifelli <gciofono@...il.com>
Cc:     Reinhard Speyerer <rspmn@...nline.de>, netdev@...r.kernel.org,
        rspmn@...or.de
Subject: Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion
 PLSx3 modem family

Reinhard Speyerer <rspmn@...nline.de> writes:

>> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>> index af19513a9f75..262d19439b34 100644
>> --- a/drivers/net/usb/qmi_wwan.c
>> +++ b/drivers/net/usb/qmi_wwan.c
>> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
>>  	{QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)},	/* Olivetti Olicard 160 */
>>  	{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},	/* Olivetti Olicard 500 */
>>  	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
>> +	{QMI_FIXED_INTF(0x1e2d, 0x006f, 8)},	/* Cinterion PLS83/PLS63 */
>> +	{QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
>>  	{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},	/* Cinterion PHxx,PXxx */
>>  	{QMI_FIXED_INTF(0x1e2d, 0x0063, 10)},	/* Cinterion ALASxx (1 RmNet) */
>>  	{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},	/* Cinterion PHxx,PXxx (2 RmNet) */
>
> Hi Giacinto,
>
> AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> examples from other UE vendors.

Yup, please fix and send a v2.  And please use get_maintainer.pl to get
the proper destinations.

Thanks for spotting this, Reinhard.  I would never have caught it with
my current netdev reading frequency....




Bjørn