netdev - Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jan 2021 13:36:01 +0100
From:   Giacinto Cifelli <gciofono@...il.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     Reinhard Speyerer <rspmn@...nline.de>, netdev@...r.kernel.org,
        rspmn@...or.de
Subject: Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion
 PLSx3 modem family

Hi Bjørn,

On Mon, Jan 18, 2021 at 10:02 PM Bjørn Mork <bjorn@...k.no> wrote:
>
> Reinhard Speyerer <rspmn@...nline.de> writes:
>
> >> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> >> index af19513a9f75..262d19439b34 100644
> >> --- a/drivers/net/usb/qmi_wwan.c
> >> +++ b/drivers/net/usb/qmi_wwan.c
> >> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
> >>      {QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)},    /* Olivetti Olicard 160 */
> >>      {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},    /* Olivetti Olicard 500 */
> >>      {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},    /* Cinterion PLxx */
> >> +    {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)},    /* Cinterion PLS83/PLS63 */
> >> +    {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
> >>      {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},    /* Cinterion PHxx,PXxx */
> >>      {QMI_FIXED_INTF(0x1e2d, 0x0063, 10)},   /* Cinterion ALASxx (1 RmNet) */
> >>      {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},    /* Cinterion PHxx,PXxx (2 RmNet) */
> >
> > Hi Giacinto,
> >
> > AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> > be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> > ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> > and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> > ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> > examples from other UE vendors.
>
> Yup, please fix and send a v2.  And please use get_maintainer.pl to get
> the proper destinations.
>

I have fixed and resent, but from your comment I might not have
selected the right line from maintaner.pl?
what I have is this:
$ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
"Bjørn Mork" <bjorn@...k.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
"David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING DRIVERS)
netdev@...r.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
<<<< this seems the right one
linux-usb@...r.kernel.org (open list:USB NETWORKING DRIVERS)
linux-kernel@...r.kernel.org (open list)

I have at the same time sent a patch for another enumeration of the
same product, for cdc_ether.  In that case, I have picked the
following line, which also looked the best fit:
  linux-usb@...r.kernel.org (open list:USB CDC ETHERNET DRIVER)

Did I misinterpret the results of the script?

Thank you,
Giacinto