netdev - Re: [Bug 209423] WARN_ON_ONCE() at rtl8169_tso_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jan 2021 16:50:10 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [Bug 209423] WARN_ON_ONCE() at rtl8169_tso_csum_v2()

On Tue, Jan 19, 2021 at 4:39 PM Juerg Haefliger
<juerg.haefliger@...onical.com> wrote:
>
> On Tue, 19 Jan 2021 14:54:31 +0100
> Eric Dumazet <edumazet@...gle.com> wrote:
>

> >
> > Oops. Very nice detective work :)
> >
> > It is true that the skb_clone() done in lan78xx (and some other usb
> > drivers) is probably triggering this issue.
> > (lan78xx is also lying about skb->truesize)
> >
> > skb_try_coalesce() bails if the target  skb is cloned, but not if the source is.
> >
> >
> > Can you try the following patch ?
>
> Works. Nice :-)
>

Excellent !

> If you submit this and care you can add:
>
> Tested-by: Juerg Haefliger <juergh@...onical.com>

Sure, I will also add a :

Bisected-by: Juerg Haefliger <juergh@...onical.com>

Because you did quite a lot of work narrowing the problem !

>
> Thanks a lot for the quick turnaround!
>
> ...Juerg
>
>