netdev - Re: [PATCH v4 net-next 15/16] net: dsa: felix: setup MMIO filtering rules for PTP when using tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120173241.4jfqhsm725wqeqic@skbuf>
Date:   Wed, 20 Jan 2021 19:32:41 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Hongbo Wang <hongbo.wang@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Po Liu <po.liu@....com>, Yangbo Lu <yangbo.lu@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        Eldar Gasanov <eldargasanov2@...il.com>,
        Andrey L <al@...omtech.com>, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v4 net-next 15/16] net: dsa: felix: setup MMIO filtering
 rules for PTP when using tag_8021q

On Wed, Jan 20, 2021 at 08:40:42AM -0800, Jakub Kicinski wrote:
> drivers/net/dsa/ocelot/felix.c:464:12: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
>   464 |  int port, err;
>       |            ^~~
> drivers/net/dsa/ocelot/felix.c:265:53: warning: incorrect type in assignment (different base types)
> drivers/net/dsa/ocelot/felix.c:265:53:    expected unsigned short [usertype]
> drivers/net/dsa/ocelot/felix.c:265:53:    got restricted __be16 [usertype]
>
>
> Please build test the patches locally, the patchwork testing thing is
> not keeping up with the volume, and it's running on the largest VM
> available thru the provider already :/

I updated my compiler now, so that W=1 C=1 builds would not fail.
That should hopefully prevent this from happening in the future.

> I need to add this "don't post your patches to get them build tested
> or you'll make Kuba very angry" to the netdev FAQ.

Since I definitely don't want to upset Kuba, how bad is it to exceed the
15 patches per series limit? Do I need to do something about it?