netdev - Re: [PATCHv4 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2673306.1611651999@warthog.procyon.org.uk>
Date:   Tue, 26 Jan 2021 09:06:39 +0000
From:   David Howells <dhowells@...hat.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     dhowells@...hat.com, network dev <netdev@...r.kernel.org>,
        davem@...emloft.net, Jakub Kicinski <kuba@...nel.org>,
        pabeni@...hat.com, Willem de Bruijn <willemb@...gle.com>,
        Martin Varghese <martin.varghese@...ia.com>,
        Alexander Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCHv4 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open_socket

Xin Long <lucien.xin@...il.com> wrote:

> -	udp_encap_enable();
> -#if IS_ENABLED(CONFIG_AF_RXRPC_IPV6)
> -	if (local->srx.transport.family == AF_INET6)
> -		udpv6_encap_enable();
> -#endif
> +	udp_tunnel_encap_enable(local->socket);

You need this too:

	--- a/net/rxrpc/local_object.c
	+++ b/net/rxrpc/local_object.c
	@@ -16,6 +16,7 @@
	 #include <linux/hashtable.h>
	 #include <net/sock.h>
	 #include <net/udp.h>
	+#include <net/udp_tunnel.h>
	 #include <net/af_rxrpc.h>
	 #include "ar-internal.h"

With that, it seems to work still:

	Acked-and-tested-by: David Howells <dhowells@...hat.com>

David