netdev - Re: [PATCHv16 bpf-next 3/6] xdp: add a new helper for dev map multicast support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Jan 2021 09:17:51 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Jiri Benc <jbenc@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>, ast@...nel.org,
        Daniel Borkmann <daniel@...earbox.net>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCHv16 bpf-next 3/6] xdp: add a new helper for dev map
 multicast support

On Mon, Jan 25, 2021 at 01:27:24PM +0100, Maciej Fijalkowski wrote:
> Hangbin,
> 
> before you submit next revision, could you try to apply imperative mood to
> your commit messages?
> 
> From Documentation/process/submitting-patches.rst:
> 
> <quote>
> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
> </quote>
> 
> That's the thing I'm trying to remind people internally and it feels like
> we keep on forgetting about that.

Hi Maciej,

Thanks for the reminder. I just see your reply after post the new version.
As I'm not a native speaker, I always not very sure what kind of mood/words
I should use in the commit message. So I just try to as polite as possible
(although I may pick some rude works that I didn't realize) and not order
people or something else based on our culture/background. I guess that's also
the reason some people forget to use "imperative mood".

I will keep this in mind for future works.

Thanks
Hangbin