netdev - Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: use mv88e6185_g1_vtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210126215314.3i3gs3bcy3rxxscp@skbuf>
Date:   Tue, 26 Jan 2021 23:53:14 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Rasmus Villemoes <rasmus.villemoes@...vas.dk>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: use
 mv88e6185_g1_vtu_getnext() for the 6250

On Mon, Jan 25, 2021 at 04:04:48PM +0100, Rasmus Villemoes wrote:
> mv88e6250_g1_vtu_getnext is almost identical to
> mv88e6185_g1_vtu_getnext, except for the 6250 only having 64 databases
> instead of 256. We can reduce code duplication by simply masking off
> the extra two garbage bits when assembling the fid from VTU op [3:0]
> and [11:8].
> 
> Reviewed-by: Tobias Waldekranz <tobias@...dekranz.com>
> Tested-by: Tobias Waldekranz <tobias@...dekranz.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@...vas.dk>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>