netdev - Re: [PATCH] lan743x: fix endianness when accessing descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210126183117.22514d0d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 26 Jan 2021 18:31:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alexey Denisov <rtgbnm@...il.com>
Cc:     bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] lan743x: fix endianness when accessing descriptors

On Mon, 25 Jan 2021 14:03:20 +0500 Alexey Denisov wrote:
> TX/RX descriptor ring fields are always little-endian, but conversion
> wasn't performed for big-endian CPUs, so the driver failed to work.
> 
> This patch makes the driver work on big-endian CPUs. It was tested and
> confirmed to work on NXP P1010 processor (PowerPC).
> 
> Signed-off-by: Alexey Denisov <rtgbnm@...il.com>

Thanks for the patch, you need to adjust the types of the members and
variables as well, otherwise sparse - the Linux type checking tool -
will start returning warnings that you interpret as le32 something
declared as CPU byteorder.