netdev - Re: [PATCH net] bonding: fix send_peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210126181920.403dfc6a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 26 Jan 2021 18:19:20 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     liaichun <liaichun@...wei.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] bonding: fix send_peer_notif data truncation

On Tue, 26 Jan 2021 11:52:01 +0000 liaichun wrote:
> send_peer_notif is u8, the value of this parameter is obtained from u8*int, the data may be truncated.
>  And in practice, more than u8(256)  characters are used.

New line before Fixes

> Fixes: 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer notifications")
> 

no new line after Fixes

> Signed-off-by: Aichun Li <liaichun@...wei.com>

Please CC these folks on v2:

BONDING DRIVER
M:	Jay Vosburgh <j.vosburgh@...il.com>
M:	Veaceslav Falico <vfalico@...il.com>
M:	Andy Gospodarek <andy@...yhouse.net>

> diff --git a/include/net/bonding.h b/include/net/bonding.h index 0960d9af7b8e..65394566d556 100644
> --- a/include/net/bonding.h
> +++ b/include/net/bonding.h
> @@ -215,7 +215,7 @@ struct bonding {
>  	 */
>  	spinlock_t mode_lock;
>  	spinlock_t stats_lock;
> -	u8	 send_peer_notif;
> +	u64	 send_peer_notif;
>  	u8       igmp_retrans;
>  #ifdef CONFIG_PROC_FS
>  	struct   proc_dir_entry *proc_entry;

This breaks 32bit builds, as the value is used in divisions.

Please fix and resend.