netdev - Re: [net-next 01/14] devlink: Add DMAC filter generic packet trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jan 2021 00:19:48 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Aya Levin <ayal@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [net-next 01/14] devlink: Add DMAC filter generic packet trap

On Wed, 2021-01-27 at 19:54 -0800, Jakub Kicinski wrote:
> On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote:
> > From: Aya Levin <ayal@...dia.com>
> > 
> > Add packet trap that can report packets that were dropped due to
> > destination MAC filtering.
> > 
> > Signed-off-by: Aya Levin <ayal@...dia.com>
> > Reviewed-by: Ido Schimmel <idosch@...dia.com>
> > Reviewed-by: Moshe Shemesh <moshe@...dia.com>
> > Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> > Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> > ---
> >  Documentation/networking/devlink/devlink-trap.rst | 5 +++++
> >  include/net/devlink.h                             | 3 +++
> >  net/core/devlink.c                                | 1 +
> >  3 files changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/networking/devlink/devlink-trap.rst
> > b/Documentation/networking/devlink/devlink-trap.rst
> > index d875f3e1e9cf..1dd86976ecf8 100644
> > --- a/Documentation/networking/devlink/devlink-trap.rst
> > +++ b/Documentation/networking/devlink/devlink-trap.rst
> > @@ -480,6 +480,11 @@ be added to the following table:
> >       - ``drop``
> >       - Traps packets that the device decided to drop in case they
> > hit a
> >         blackhole nexthop
> > +   * - ``dmac_filter``
> > +     - ``drop``
> > +     - Traps incoming packets that the device decided to drop in
> > case
> 
> s/in case/because/
> 
> > +       the destination MAC is not configured in the MAC table
> 
> ... and the interface is not in promiscuous mode
> 

Makes sense ! 

> > +
> 
> Double new line
> 
> >  Driver-specific Packet Traps
> >  ============================
> 
> Fix that up and applied from the list.

Thanks,
I can stop sending pull requests and siwtch to normal patchsets 
if this will be more convenient to you/

to me is just converting the cover letter :)..