netdev - Re: [net-next 01/14] devlink: Add DMAC filter generic packet trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210128083828.6cb1d25f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 28 Jan 2021 08:38:28 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Aya Levin <ayal@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [net-next 01/14] devlink: Add DMAC filter generic packet trap

On Thu, 28 Jan 2021 00:19:48 -0800 Saeed Mahameed wrote:
> On Wed, 2021-01-27 at 19:54 -0800, Jakub Kicinski wrote:
> > On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote:  
> > > From: Aya Levin <ayal@...dia.com>
> > > 
> > > Add packet trap that can report packets that were dropped due to
> > > destination MAC filtering.
> > > 
> > > Signed-off-by: Aya Levin <ayal@...dia.com>
> > > Reviewed-by: Ido Schimmel <idosch@...dia.com>
> > > Reviewed-by: Moshe Shemesh <moshe@...dia.com>
> > > Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> > > Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> > > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> > 
> > s/in case/because/
> >   
> > > +       the destination MAC is not configured in the MAC table  
> > 
> > ... and the interface is not in promiscuous mode
> >   
> 
> Makes sense ! 
> 
> > > +  
> > 
> > Double new line
> >   
> > >  Driver-specific Packet Traps
> > >  ============================  
> > 
> > Fix that up and applied from the list.  
> 
> Thanks,
> I can stop sending pull requests and siwtch to normal patchsets 
> if this will be more convenient to you/
> 
> to me is just converting the cover letter :).. 

No preference on my side, as long as the patches are on the ML it's just
the matter of remembering which parameters to pass to my scripts :)