netdev - Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210201180606.GA3456040@shredder.lan>
Date:   Mon, 1 Feb 2021 20:06:06 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Chris Mi <cmi@...dia.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jiri@...dia.com,
        saeedm@...dia.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC
 driver dependency

On Mon, Feb 01, 2021 at 10:00:48AM +0800, Chris Mi wrote:
> On 1/30/2021 10:52 PM, Ido Schimmel wrote:
> > On Sat, Jan 30, 2021 at 10:33:19AM +0800, Chris Mi wrote:
> > > In order to send sampled packets to userspace, NIC driver calls
> > > psample api directly. But it creates a hard dependency on module
> > > psample. Introduce psample_ops to remove the hard dependency.
> > > It is initialized when psample module is loaded and set to NULL
> > > when the module is unloaded.
> > > 
> > > Reported-by: kernel test robot <lkp@...el.com>
> > This belongs in the changelog (that should be part of the commit
> > message). Something like "Fix xxx reported by kernel test robot".
> But I see existing commits have it.

It is used by commits whose sole purpose is to fix an issue that was
reported by the kernel test robot. In this case the robot merely
reported an issue with your v1. If you want to give credit, use the form
I suggested above. It is misleading otherwise.