netdev - Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210201131051.4937f0ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 1 Feb 2021 13:10:51 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Chris Mi <cmi@...dia.com>
Cc:     <netdev@...r.kernel.org>, <jiri@...dia.com>, <saeedm@...dia.com>,
        "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC
 driver dependency

On Mon, 1 Feb 2021 09:32:15 +0800 Chris Mi wrote:
> On 1/30/2021 2:59 PM, Jakub Kicinski wrote:
> > On Sat, 30 Jan 2021 10:33:19 +0800 Chris Mi wrote:  
> >> +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
> >> +/* Copyright (c) 2021 Mellanox Technologies. */
> >> +
> >> +const struct psample_ops __rcu *psample_ops __read_mostly;
> >> +EXPORT_SYMBOL_GPL(psample_ops);  
> > Please explain to me how you could possibly have compile tested this
> > and not caught that it doesn't build.  
> Sorry, I don't understand which issue you are talking about. Do you mean
> the issue sparse found before or new issues in v5?

There is no include here now, and it uses EXPORT_SYMBOL_GPL() 
and a bunch of decorators.