netdev - Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Feb 2021 16:08:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Chris Mi <cmi@...dia.com>, netdev@...r.kernel.org, jiri@...dia.com,
        saeedm@...dia.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC
 driver dependency

On Mon, 1 Feb 2021 20:06:06 +0200 Ido Schimmel wrote:
> On Mon, Feb 01, 2021 at 10:00:48AM +0800, Chris Mi wrote:
> > On 1/30/2021 10:52 PM, Ido Schimmel wrote:  
> > > This belongs in the changelog (that should be part of the commit
> > > message). Something like "Fix xxx reported by kernel test robot".  
> > But I see existing commits have it.  
> 
> It is used by commits whose sole purpose is to fix an issue that was
> reported by the kernel test robot. In this case the robot merely
> reported an issue with your v1. If you want to give credit, use the form
> I suggested above. It is misleading otherwise.

Personally I fully agree. But some people pushed back on this in 
the past saying buildbot should be credited for early detection, 
too - otherwise the funding may dry up. So I don't care either 
way now :)