netdev - Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 09:42:32 +0800
From:   Chris Mi <cmi@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <jiri@...dia.com>, <saeedm@...dia.com>,
        "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC
 driver dependency

On 2/2/2021 5:10 AM, Jakub Kicinski wrote:
> On Mon, 1 Feb 2021 09:32:15 +0800 Chris Mi wrote:
>> On 1/30/2021 2:59 PM, Jakub Kicinski wrote:
>>> On Sat, 30 Jan 2021 10:33:19 +0800 Chris Mi wrote:
>>>> +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
>>>> +/* Copyright (c) 2021 Mellanox Technologies. */
>>>> +
>>>> +const struct psample_ops __rcu *psample_ops __read_mostly;
>>>> +EXPORT_SYMBOL_GPL(psample_ops);
>>> Please explain to me how you could possibly have compile tested this
>>> and not caught that it doesn't build.
>> Sorry, I don't understand which issue you are talking about. Do you mean
>> the issue sparse found before or new issues in v5?
> There is no include here now, and it uses EXPORT_SYMBOL_GPL()
> and a bunch of decorators.
>
But there is no errors in 'checks' section of this page:
https://patchwork.kernel.org/project/netdevbpf/patch/20210128014543.521151-1-cmi@nvidia.com/

And I followed kernel test robot guide, I reproduced the errors in v1, 
but I fixed it in v2.

reproduce:

         wgethttps://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross  -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # apt-get install sparse
         # sparse version: v0.6.3-212-g56dbccf5-dirty
         #https://github.com/0day-ci/linux/commit/f2df98afc1a1f1809d9e8a178b2d4766cbca8bf7
         git remote add linux-reviewhttps://github.com/0day-ci/linux
         git fetch --no-tags linux-review Chris-Mi/net-psample-Introduce-stubs-to-remove-NIC-driver-dependency/20210127-082451
         git checkout f2df98afc1a1f1809d9e8a178b2d4766cbca8bf7
         # save the attached .config to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390

I didn't see errors even if there is no include.