netdev - Re: [PATCH net-next] net: dsa: bcm_sf2: Check egress tagging of CFP rule with proper accessor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <882c3e59-0e2b-46cf-3211-bb88427a3328@gmail.com>
Date:   Wed, 3 Feb 2021 10:21:24 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: Check egress tagging of CFP
 rule with proper accessor

On 1/29/21 3:56 AM, Vladimir Oltean wrote:
> The flow steering struct ethtool_flow_ext::data field is __be32, so when
> the CFP code needs to check the VLAN egress tagging attribute in bit 0,
> it does this in CPU native endianness. So logically, the endianness
> conversion is set up the other way around, although in practice the same
> result is produced.
> 
> Gets rid of build warning:
> 
> warning: cast from restricted __be32
> warning: incorrect type in argument 1 (different base types)
>    expected unsigned int [usertype] val
>    got restricted __be32
> warning: cast from restricted __be32
> warning: cast from restricted __be32
> warning: cast from restricted __be32
> warning: cast from restricted __be32
> warning: restricted __be32 degrades to integer
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian