netdev - Re: [PATCH] net: tracepoint: exposing sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL70W4qyRuHaPGw96sx=XKXLPe9OkhtneF+JU9WaQ1ko25TxRA@mail.gmail.com>
Date:   Wed, 3 Feb 2021 10:25:11 -0800
From:   Hariharan Ananthakrishnan <hari@...flix.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     sdf@...gle.com, Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Song Liu <songliubraving@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Brendan Gregg <bgregg@...flix.com>
Subject: Re: [PATCH] net: tracepoint: exposing sk_family in all tcp:tracepoints

On Wed, Feb 3, 2021 at 10:16 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 3 Feb 2021 08:26:04 -0800 sdf@...gle.com wrote:
> > On 02/02, Eric Dumazet wrote:
> > > On Mon, Feb 1, 2021 at 11:06 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > > > Eric, any thoughts?
> >
> > > I do not use these tracepoints in production scripts, but I wonder if
> > > existing tools could break after this change ?
> >
> > > Or do we consider tracepoints format is not part of the ABI and can be
> > > arbitrarily changed by anyone ?
> >
> > They are not ABI and since we are extending tracepoints with additional
> > info (and not removing any existing fields) it shouldn't be a problem.
>
> Okay, but we should perhaps add the field at the end just to be on the
> safe side (and avoid weird alignment of the IP addresses).
I added it after dport to be consistent with the earlier patch to
sock:inet_sock_set_state
https://lore.kernel.org/patchwork/patch/870492/.