netdev - Re: [net v2] selftests: txtimestamp: fix compilation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-Ksu5cwE9KK9Te4Cpz+57Aa19UHxtHpHoxQMBiB4d=zgw@mail.gmail.com>
Date:   Thu, 4 Feb 2021 10:50:57 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>
Cc:     Jakub Kicinski <kuba@...nel.org>, Jian Yang <jianyang@...gle.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [net v2] selftests: txtimestamp: fix compilation issue

On Thu, Feb 4, 2021 at 10:21 AM Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
>
> PACKET_TX_TIMESTAMP is defined in if_packet.h but it is not included in
> test. It could be included instead of <netpacket/packet.h> otherwise
> the error of redefinition arrives.
>
> Fixes: 8fe2f761cae9 (net-timestamp: expand documentation)

Needs quotes

  Fixes: 8fe2f761cae9 ("net-timestamp: expand documentation")

When resending, can you also revise "It could be included instead .. "
to "Include instead .."

And mention in the commit the other warning fixed at the same time.
Thanks for including that.

> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>