netdev - Re: [net v2] selftests: txtimestamp: fix compilation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f853954e-f935-e3e5-2e2d-8acaa1cd266f@novek.ru>
Date:   Thu, 4 Feb 2021 16:23:14 +0000
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, Jian Yang <jianyang@...gle.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [net v2] selftests: txtimestamp: fix compilation issue

On 04.02.2021 15:50, Willem de Bruijn wrote:
> On Thu, Feb 4, 2021 at 10:21 AM Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
>>
>> PACKET_TX_TIMESTAMP is defined in if_packet.h but it is not included in
>> test. It could be included instead of <netpacket/packet.h> otherwise
>> the error of redefinition arrives.
>>
>> Fixes: 8fe2f761cae9 (net-timestamp: expand documentation)
> 
> Needs quotes
> 
>    Fixes: 8fe2f761cae9 ("net-timestamp: expand documentation")
> 
> When resending, can you also revise "It could be included instead .. "
> to "Include instead .."
> 
> And mention in the commit the other warning fixed at the same time.
> Thanks for including that.
> 
>> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
>> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>

Ok, no problem. Thanks for reviewing!