netdev - Re: [PATCH net-next] net: dsa: xrs700x: Correctly address device over I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210204191149.2eecf944@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 4 Feb 2021 19:11:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     George McCollister <george.mccollister@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: xrs700x: Correctly address device
 over I2C

On Tue, 2 Feb 2021 14:05:20 -0600 George McCollister wrote:
> On Tue, Feb 2, 2021 at 1:17 PM Tobias Waldekranz <tobias@...dekranz.com> wrote:
> [snip]
> >
> > George, have you used the chip in I2C mode with the code that is on
> > net-next now? I was not able to get the driver to even read the ID
> > register correctly.  
> 
> I wrote the i2c driver before I had any hardware in hand thinking I
> was going to get a board with the switch connected via i2c. When the
> board arrived it turned out it was connected via mdio so I wrote that
> driver as well. I looked it over quite carefully but I guess the
> documentation was wrong and I had the register addresses shifted off
> by one. I never ended up with hardware to test the i2c.

> Reviewed-by: George McCollister <george.mccollister@...il.com>

Applied, thanks!