netdev - 答复: [PATCH net-next] net: core: Remove extra spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 03:13:48 +0000
From:   zhengyongjun <zhengyongjun3@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH net-next] net: core: Remove extra spaces

Thank you, I will do this code style cleanup in ` net/core/neighbour.c` to fix the worse style issues you said :)

-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@...nel.org] 
发送时间: 2021年2月5日 11:05
收件人: zhengyongjun <zhengyongjun3@...wei.com>
抄送: davem@...emloft.net; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH net-next] net: core: Remove extra spaces

On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
> Do codingstyle clean up to remove extra spaces.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  net/core/neighbour.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 
> 9500d28a43b0..72ea94ec8c4a 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct 
> net_device *dev,
>  
>  	p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
>  	if (p) {
> -		p->tbl		  = tbl;
> +		p->tbl = tbl;
>  		refcount_set(&p->refcnt, 1);
>  		p->reachable_time =

                                  ^

It's aligned with the assignment to reachable_time.

I don't find this particularly offensive, there are worse style issues in this function.

>  				neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));