netdev - Re: [PATCH net-next] rxrpc: use udp tunnel APIs instead of open code in rxrpc_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d85e5bc1-8e74-321d-e727-f669a55da90f@novek.ru>
Date:   Sun, 7 Feb 2021 14:23:25 +0000
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Howells <dhowells@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        David Howells <dhowells@...hat.com>
Subject: Re: [PATCH net-next] rxrpc: use udp tunnel APIs instead of open code
 in rxrpc_open_socket

On 07.02.2021 08:23, Xin Long wrote:
> In rxrpc_open_socket(), now it's using sock_create_kern() and
> kernel_bind() to create a udp tunnel socket, and other kernel
> APIs to set up it. These code can be replaced with udp tunnel
> APIs udp_sock_create() and setup_udp_tunnel_sock(), and it'll
> simplify rxrpc_open_socket().
> 
> Note that with this patch, the udp tunnel socket will always
> bind to a random port if transport is not provided by users,
> which is suggested by David Howells, thanks!
> 
> Acked-by: David Howells <dhowells@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Looks good to me.

Reviewed-by: Vadim Fedorenko <vfedorenko@...ek.ru>