netdev - Re: [PATCH v3 net-next 01/21] iov_iter: Introduce new procedures for copy to iter/pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <736bdc2f-8073-6d34-9509-182ed1ab2b4f@gmail.com>
Date:   Sun, 7 Feb 2021 16:24:47 +0200
From:   Boris Pismenny <borispismenny@...il.com>
To:     Christoph Hellwig <hch@....de>, Or Gerlitz <gerlitz.or@...il.com>
Cc:     Boris Pismenny <borisp@...lanox.com>, smalin@...vell.com,
        Sagi Grimberg <sagi@...mberg.me>, yorayz@...dia.com,
        boris.pismenny@...il.com, Ben Ben-Ishay <benishay@...lanox.com>,
        Yoray Zack <yorayz@...lanox.com>,
        linux-nvme@...ts.infradead.org, David Miller <davem@...emloft.net>,
        axboe@...com, Eric Dumazet <edumazet@...gle.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        David Ahern <dsahern@...il.com>,
        Keith Busch <kbusch@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Or Gerlitz <ogerlitz@...lanox.com>, benishay@...dia.com,
        Saeed Mahameed <saeedm@...dia.com>,
        Or Gerlitz <ogerlitz@...dia.com>,
        Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH v3 net-next 01/21] iov_iter: Introduce new procedures for
 copy to iter/pages

On 03/02/2021 18:56, Christoph Hellwig wrote:
> On Tue, Feb 02, 2021 at 08:00:51PM +0200, Or Gerlitz wrote:
>> will look into this, any idea for a more suitable location?
> 
> Maybe just a new file under lib/ for now?
> 

That doesn't work unless we copy quite a lot of code. There are macros
here (in lib/iov_iter.c) that we rely on, e.g. iterate_and_advance and
friends.

Instead, I propose that we place all of the new code under an ifdef to
reduce the impact on object size if the code is unused. We'll also
improve documentation around this commit.