netdev - Re: [PATCH net-next 03/12] net: hns3: check cmdq message parameters sent from VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208133447.14e1118a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 8 Feb 2021 13:34:47 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Huazhong Tan <tanhuazhong@...wei.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <huangdaode@...wei.com>, <linuxarm@...neuler.org>,
        Yufeng Mo <moyufeng@...wei.com>
Subject: Re: [PATCH net-next 03/12] net: hns3: check cmdq message parameters
 sent from VF

On Mon, 8 Feb 2021 19:39:33 +0800 Huazhong Tan wrote:
> From: Yufeng Mo <moyufeng@...wei.com>
> 
> The parameters sent from VF may be unreliable. If these
> parameters are used directly, memory overwriting may occur.
> Therefore, we need to check parameters before using.
> 
> Signed-off-by: Yufeng Mo <moyufeng@...wei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>

Are you sure this is not a fix which should target net and stable?

Other than that the patches look good to me.