netdev - Re: [PATCH net-next 03/12] net: hns3: check cmdq message parameters sent from VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac2f3605-a724-3196-6709-d24491a06f10@huawei.com>
Date:   Tue, 9 Feb 2021 09:26:10 +0800
From:   Huazhong Tan <tanhuazhong@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <huangdaode@...wei.com>, <linuxarm@...neuler.org>,
        Yufeng Mo <moyufeng@...wei.com>
Subject: Re: [PATCH net-next 03/12] net: hns3: check cmdq message parameters
 sent from VF


On 2021/2/9 5:34, Jakub Kicinski wrote:
> On Mon, 8 Feb 2021 19:39:33 +0800 Huazhong Tan wrote:
>> From: Yufeng Mo <moyufeng@...wei.com>
>>
>> The parameters sent from VF may be unreliable. If these
>> parameters are used directly, memory overwriting may occur.
>> Therefore, we need to check parameters before using.
>>
>> Signed-off-by: Yufeng Mo <moyufeng@...wei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> Are you sure this is not a fix which should target net and stable?


Yes, this patch should be a fix for below:

Fixes: 1a426f8b40fc ("net: hns3: fix the VF queue reset flow error")
Fixes: 84e095d64ed9 ("net: hns3: Change PF to add ring-vect binding & 
resetQ to mailbox")
Fixes: a638b1d8cc87 ("net: hns3: fix get VF RSS issue")


>
> Other than that the patches look good to me.


Could you apply other patches into -next? and i resend this one for the net.

Or I send a V2 without this patch?


>
> .