netdev - Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6022303458ba9_13a65f208f7@john-XPS-13-9370.notmuch>
Date:   Mon, 08 Feb 2021 22:48:20 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        jiang.wang@...edance.com, Cong Wang <cong.wang@...edance.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to
 BPF_SOCK_MAP

Cong Wang wrote:
> On Mon, Feb 8, 2021 at 12:21 AM John Fastabend <john.fastabend@...il.com> wrote:
> >
> > Cong Wang wrote:
> > > From: Cong Wang <cong.wang@...edance.com>
> > >
> > > Before we add non-TCP support, it is necessary to rename
> > > BPF_STREAM_PARSER as it will be no longer specific to TCP,
> > > and it does not have to be a parser either.
> > >
> > > This patch renames BPF_STREAM_PARSER to BPF_SOCK_MAP, so
> > > that sock_map.c hopefully would be protocol-independent.
> > >
> > > Also, improve its Kconfig description to avoid confusion.
> > >
> > > Cc: John Fastabend <john.fastabend@...il.com>
> > > Cc: Daniel Borkmann <daniel@...earbox.net>
> > > Cc: Jakub Sitnicki <jakub@...udflare.com>
> > > Cc: Lorenz Bauer <lmb@...udflare.com>
> > > Signed-off-by: Cong Wang <cong.wang@...edance.com>
> > > ---
> >
> > The BPF_STREAM_PARSER config was originally added because we need
> > the STREAM_PARSER define and wanted a way to get the 'depends on'
> > lines in Kconfig correct.
> >
> > Rather than rename this, lets reduce its scope to just the set
> > of actions that need the STREAM_PARSER, this should be just the
> > stream parser programs. We probably should have done this sooner,
> > but doing it now will be fine.
> 
> This makes sense, but we still need a Kconfig for the rest sockmap
> code, right? At least for the dependency on NET_SOCK_MSG?

Lets just enable NET_SOCK_MSG when CONFIG_BPF_SYSCALL is enabled. We
never put any of the other maps, devmap, cpumap, etc. behind an
explicit flag like this.

> 
> >
> > I can probably draft a quick patch tomorrow if above is not clear.
> > It can go into bpf-next outside this series as well to reduce
> > the 19 patches a bit.
> 
> I can handle it in my next update too, like all other feedbacks.

Great thanks. Especially because I haven't got to it yet today.

> 
> Thanks.