netdev - Re: [PATCH net-next] net/mlx5: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ygnhczx8gngw.fsf@nvidia.com>
Date:   Wed, 10 Feb 2021 13:40:31 +0200
From:   Vlad Buslov <vladbu@...dia.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Dmytro Linkin <dlinkin@...dia.com>,
        Roi Dayan <roid@...dia.com>, <netdev@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: Fix a NULL vs IS_ERR() check

On Wed 10 Feb 2021 at 13:06, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> The mlx5_chains_get_table() function doesn't return NULL, it returns
> error pointers so we need to fix this condition.
>
> Fixes: 34ca65352ddf ("net/mlx5: E-Switch, Indirect table infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks, Dan!

Reviewed-by: Vlad Buslov <vladbu@...dia.com>