netdev - RE: [PATCH net-next 4/9] lan78xx: disable MAC address filter before updating entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 15:33:27 -0000
From:   "John Efstathiades" <john.efstathiades@...blebay.com>
To:     "'Andrew Lunn'" <andrew@...n.ch>
Cc:     <UNGLinuxDriver@...rochip.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <Woojung.Huh@...rochip.com>
Subject: RE: [PATCH net-next 4/9] lan78xx: disable MAC address filter before updating entry



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: 04 February 2021 13:46
> 
> On Thu, Feb 04, 2021 at 11:31:16AM +0000, John Efstathiades wrote:
> > Disable the station MAC address entry in the perfect address filter
> > table before updating the table entry with a new MAC address.
> 
> This seems like a real fix. Please base this on net, not net-next, and
> add a Fixes: tag.

Thanks, I'll do that.

> > -	/* Added to support MAC address changes */
> > -	lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
> > -	lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
> > +	/* The station MAC address in the perfect address filter table
> > +	 * must also be updated to ensure frames are received
> > +	 */
> > +	ret = lan78xx_write_reg(dev, MAF_HI(0), 0);
> > +	ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
> > +	ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
> 
> Why bother with ret is you are going to 1) overwrite it, 2) ignore it!

This is a side-effect of my rebase on the latest net-next tree and linked to
patch 9/9 in this set, which you also commented on.

I need to change the way I rebased my work on the latest driver code so this
goes away.

John