lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKgT0UecsEG8C=U8A8iFQNBMsKU_ZLESz+4p6xQXc4+w=Bcp2Q@mail.gmail.com>
Date:   Wed, 10 Feb 2021 13:05:32 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     Netdev <netdev@...r.kernel.org>, roopa@...dia.com,
        Andy Gospodarek <andy@...yhouse.net>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>, idosch@...dia.com,
        Nikolay Aleksandrov <nikolay@...dia.com>
Subject: Re: [PATCH net-next v2 0/3] bonding: 3ad: support for 200G/400G ports
 and more verbose warning

On Wed, Feb 10, 2021 at 12:43 PM Nikolay Aleksandrov
<razor@...ckwall.org> wrote:
>
> From: Nikolay Aleksandrov <nikolay@...dia.com>
>
> Hi,
> We'd like to have proper 200G and 400G support with 3ad bond mode, so we
> need to add new definitions for them in order to have separate oper keys,
> aggregated bandwidth and proper operation (patches 01 and 02). In
> patch 03 Ido changes the code to use pr_err_once instead of
> pr_warn_once which would help future detection of unsupported speeds.
>
> v2: patch 03: use pr_err_once instead of WARN_ONCE
>
> Thanks,
>  Nik
>
> Ido Schimmel (1):
>   bonding: 3ad: Print an error for unknown speeds
>
> Nikolay Aleksandrov (2):
>   bonding: 3ad: add support for 200G speed
>   bonding: 3ad: add support for 400G speed
>
>  drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>

With this update the series looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ