[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a087531e-59f3-cadb-da69-e6b1e7b521f2@nvidia.com>
Date: Fri, 12 Feb 2021 17:59:24 +0200
From: Nikolay Aleksandrov <nikolay@...dia.com>
To: Vladimir Oltean <olteanv@...il.com>,
Jakub Kicinski <kuba@...nel.org>,
"David S. Miller" <davem@...emloft.net>
CC: Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<bridge@...ts.linux-foundation.org>,
"Roopa Prabhu" <roopa@...dia.com>, Jiri Pirko <jiri@...nulli.us>,
Ido Schimmel <idosch@...sch.org>,
Claudiu Manoil <claudiu.manoil@....com>,
"Alexandre Belloni" <alexandre.belloni@...tlin.com>,
<UNGLinuxDriver@...rochip.com>, Vadym Kochan <vkochan@...vell.com>,
Taras Chornyi <tchornyi@...vell.com>,
Grygorii Strashko <grygorii.strashko@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Ioana Ciornei <ioana.ciornei@....com>,
Ivan Vecera <ivecera@...hat.com>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v5 net-next 03/10] net: bridge: don't print in
br_switchdev_set_port_flag
On 12/02/2021 17:15, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
>
> For the netlink interface, propagate errors through extack rather than
> simply printing them to the console. For the sysfs interface, we still
> print to the console, but at least that's one layer higher than in
> switchdev, which also allows us to silently ignore the offloading of
> flags if that is ever needed in the future.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> Changes in v5:
> None.
>
> Changes in v4:
> - Adjust the commit message now that we aren't notifying initial and
> final port flags from the bridge any longer.
>
> Changes in v3:
> - Deal with the br_switchdev_set_port_flag call from sysfs too.
>
> Changes in v2:
> - br_set_port_flag now returns void, so no extack there.
> - don't overwrite extack in br_switchdev_set_port_flag if already
> populated.
>
> net/bridge/br_netlink.c | 9 +++++----
> net/bridge/br_private.h | 6 ++++--
> net/bridge/br_switchdev.c | 13 +++++++------
> net/bridge/br_sysfs_if.c | 7 +++++--
> 4 files changed, 21 insertions(+), 14 deletions(-)
>
Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>
Powered by blists - more mailing lists