netdev - Re: Refcount mismatch when unregistering netdevice from kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQL4PSQd79fjkwWnq0C_1rLT3rwUOs4aWK67i9DVHuysWA@mail.gmail.com>
Date:   Thu, 11 Feb 2021 17:44:01 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Wei Wang <weiwan@...gle.com>, David Ahern <dsahern@...il.com>,
        stranche@...eaurora.org, Eric Dumazet <eric.dumazet@...il.com>,
        Martin KaFai Lau <kafai@...com>,
        Mahesh Bandewar <maheshb@...gle.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Subject: Re: Refcount mismatch when unregistering netdevice from kernel

On Thu, Feb 11, 2021 at 5:28 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 11 Feb 2021 11:21:26 -0800 Alexei Starovoitov wrote:
> > On Tue, Jan 5, 2021 at 11:11 AM Wei Wang <weiwan@...gle.com> wrote:
> > > On Mon, Jan 4, 2021 at 8:58 PM David Ahern <dsahern@...il.com> wrote:
> > > > On 1/4/21 8:05 PM, stranche@...eaurora.org wrote:
> > > Ah, I see now. rt6_flush_exceptions is called by fib6_del_route, but
> > > > that won't handle replace.
> > > >
> > > > If you look at fib6_purge_rt it already has a call to remove pcpu
> > > > entries. This call to flush exceptions should go there and the existing
> > > > one in fib6_del_route can be removed.
> > > >
> > > Thanks for catching this!
> > > Agree with this proposed fix.
> >
> > Looks like this fix never landed?
> > Is it still needed or there was an alternative fix merged?
>
> Wasn't it:
>
> d8f5c29653c3 ("net: ipv6: fib: flush exceptions when purging route")
>
> ?

Ahh. Thanks!