[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d3a64aea-d544-cd58-475c-57e89ea49be5@gmail.com>
Date: Sat, 13 Feb 2021 12:16:45 -0700
From: David Ahern <dsahern@...il.com>
To: Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc: David Ahern <dsahern@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH 03/13] nexthop: Add netlink defines and enumerators
for resilient NH groups
On 2/8/21 1:42 PM, Petr Machata wrote:
> @@ -52,8 +53,50 @@ enum {
> NHA_FDB, /* flag; nexthop belongs to a bridge fdb */
> /* if NHA_FDB is added, OIF, BLACKHOLE, ENCAP cannot be set */
>
> + /* nested; resilient nexthop group attributes */
> + NHA_RES_GROUP,
> + /* nested; nexthop bucket attributes */
> + NHA_RES_BUCKET,
> +
> __NHA_MAX,
> };
>
> #define NHA_MAX (__NHA_MAX - 1)
> +
> +enum {
> + NHA_RES_GROUP_UNSPEC,
> + /* Pad attribute for 64-bit alignment. */
> + NHA_RES_GROUP_PAD = NHA_RES_GROUP_UNSPEC,
> +
> + /* u32; number of nexthop buckets in a resilient nexthop group */
> + NHA_RES_GROUP_BUCKETS,
u32 is overkill; arguably u16 (64k) should be more than enough buckets
for any real use case.
Powered by blists - more mailing lists