netdev - Re: [RFC PATCH 00/13] nexthop: Resilient next-hop groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ece022f-ec32-ab38-d2cf-a699c17bbcc7@gmail.com>
Date:   Sat, 13 Feb 2021 12:17:54 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org,
        David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH 00/13] nexthop: Resilient next-hop groups

On 2/13/21 12:16 PM, Ido Schimmel wrote:
> On Sat, Feb 13, 2021 at 11:57:03AM -0700, David Ahern wrote:
>> On 2/8/21 1:42 PM, Petr Machata wrote:
>>> To illustrate the usage, consider the following commands:
>>>
>>>  # ip nexthop add id 1 via 192.0.2.2 dev dummy1
>>>  # ip nexthop add id 2 via 192.0.2.3 dev dummy1
>>>  # ip nexthop add id 10 group 1/2 type resilient \
>>> 	buckets 8 idle_timer 60 unbalanced_timer 300
>>>
>>> The last command creates a resilient next hop group. It will have 8
>>> buckets, each bucket will be considered idle when no traffic hits it for at
>>> least 60 seconds, and if the table remains out of balance for 300 seconds,
>>> it will be forcefully brought into balance. (If not present in netlink
>>> message, the idle timer defaults to 120 seconds, and there is no unbalanced
>>> timer, meaning the group may remain unbalanced indefinitely.)
>>
>> How did you come up with the default timer of 120 seconds?
> 
> It is the default in the Cumulus Linux implementation (deployed for
> several years already), so we figured it should be OK.
> 

Add that to the commit log.