netdev - Re: [RFC PATCH 04/13] nexthop: Add implementation of resilient next-hop groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bd96142-9dce-efb5-8ac6-d4aa62441fa4@gmail.com>
Date:   Sat, 13 Feb 2021 12:22:33 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH 04/13] nexthop: Add implementation of resilient
 next-hop groups

On 2/8/21 1:42 PM, Petr Machata wrote:
> @@ -212,7 +254,7 @@ static inline bool nexthop_is_multipath(const struct nexthop *nh)
>  		struct nh_group *nh_grp;
>  
>  		nh_grp = rcu_dereference_rtnl(nh->nh_grp);
> -		return nh_grp->mpath;
> +		return nh_grp->mpath || nh_grp->resilient;

That pattern shows up multiple times; since this is datapath, it would
be worth adding a new bool for it (is_multipath or has_nexthops or
something else along those lines)