netdev - Re: [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202102131509.tNiKQPgX-lkp@intel.com>
Date:   Sat, 13 Feb 2021 15:42:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support
 for PTP timestamping

Hi Vladimir,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-a011-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/252148a7a654decce0740262c5425991fd53156e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
        git checkout 252148a7a654decce0740262c5425991fd53156e
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: net/dsa/tag_ocelot_8021q.o: in function `ocelot_xmit_ptp':
>> net/dsa/tag_ocelot_8021q.c:34: undefined reference to `ocelot_port_inject_frame'


vim +34 net/dsa/tag_ocelot_8021q.c

    15	
    16	static struct sk_buff *ocelot_xmit_ptp(struct dsa_port *dp,
    17					       struct sk_buff *skb,
    18					       struct sk_buff *clone)
    19	{
    20		struct ocelot *ocelot = dp->ds->priv;
    21		struct ocelot_port *ocelot_port;
    22		int port = dp->index;
    23		u32 rew_op;
    24	
    25		ocelot_port = ocelot->ports[port];
    26		rew_op = ocelot_port->ptp_cmd;
    27	
    28		/* Retrieve timestamp ID populated inside skb->cb[0] of the
    29		 * clone by ocelot_port_add_txtstamp_skb
    30		 */
    31		if (ocelot_port->ptp_cmd == IFH_REW_OP_TWO_STEP_PTP)
    32			rew_op |= clone->cb[0] << 3;
    33	
  > 34		ocelot_port_inject_frame(ocelot, port, 0, rew_op, skb);
    35	
    36		return NULL;
    37	}
    38	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (39785 bytes)