netdev - Re: [PATCH net-next 2/2] tcp: factorize logic into tcp_epollin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ-Y9avDrs3Jbx93J8zwMFfrY8Pq1LAL6tYWDvtcfdWKg@mail.gmail.com>
Date:   Sat, 13 Feb 2021 08:50:59 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Wei Wang <weiwan@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, Arjun Roy <arjunroy@...gle.com>
Subject: Re: [PATCH net-next 2/2] tcp: factorize logic into tcp_epollin_ready()

On Sat, Feb 13, 2021 at 1:30 AM Wei Wang <weiwan@...gle.com> wrote:
>

> >  void tcp_data_ready(struct sock *sk)
> >  {
> > -       const struct tcp_sock *tp = tcp_sk(sk);
> > -       int avail = tp->rcv_nxt - tp->copied_seq;
> > -
> > -       if (avail < sk->sk_rcvlowat && !tcp_rmem_pressure(sk) &&
> > -           !sock_flag(sk, SOCK_DONE) &&
>
> Seems "!sock_flag(sk, SOCK_DONE)" is not checked in
> tcp_epollin_read(). Does it matter?
>


Yes, probably, good catch.

Not sure where tcp_poll() gets this, I have to double check.

Thanks !