netdev - Re: [PATCH v2 net-next 10/12] net: mscc: ocelot: refactor ocelot_xtr_irq_handler into ocelot_xtr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6397474-f8ae-8308-d0a0-51472b25fe63@gmail.com>
Date:   Sat, 13 Feb 2021 18:57:49 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v2 net-next 10/12] net: mscc: ocelot: refactor
 ocelot_xtr_irq_handler into ocelot_xtr_poll



On 2/13/2021 14:37, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Since the felix DSA driver will need to poll the CPU port module for
> extracted frames as well, let's create some common functions that read
> an Extraction Frame Header, and then an skb, from a CPU extraction
> group.
> 
> We abuse the struct ocelot_ops :: port_to_netdev function a little bit,
> in order to retrieve the DSA port net_device or the ocelot switchdev
> net_device based on the source port information from the Extraction
> Frame Header, but it's all in the benefit of code simplification -
> netdev_alloc_skb needs it. Originally, the port_to_netdev method was
> intended for parsing act->dev from tc flower offload code.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian