netdev - Re: [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdUs8_6_bK1-TS2Bi9vQvLJLsr8C+Y5xXF2_FJHsFKeFQ@mail.gmail.com>
Date:   Thu, 18 Feb 2021 17:04:02 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Calvin Johnson <calvin.johnson@....nxp.com>
Cc:     Grant Likely <grant.likely@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Jeremy Linton <jeremy.linton@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Madalin Bucur <madalin.bucur@....nxp.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>,
        Jon <jon@...id-run.com>, Saravana Kannan <saravanak@...gle.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Diana Madalina Craciun <diana.craciun@....com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "linux.cj" <linux.cj@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Ioana Radulescu <ruxandra.radulescu@....com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for
 DPAA2 MAC driver

On Thu, Feb 18, 2021 at 7:29 AM Calvin Johnson
<calvin.johnson@....nxp.com> wrote:
>
> Modify dpaa2_mac_get_node() to get the dpmac fwnode from either
> DT or ACPI.
>
> Modify dpaa2_mac_get_if_mode() to get interface mode from dpmac_node
> which is a fwnode.
>
> Modify dpaa2_pcs_create() to create pcs from dpmac_node fwnode.
>
> Modify dpaa2_mac_connect() to support ACPI along with DT.

...

> +                       if (is_of_node(fwnode))

Redundant check I think. If it's not an fwnode, the dpmacs is NULL and
of_node_put() is NULL-aware.

> +                               of_node_put(dpmacs);

...

> +       if (is_of_node(fwnode))
> +               of_node_put(dpmacs);

Ditto.

...

>         mac->if_link_type = mac->attr.link_type;
> -

Do we need to remove this blank line?

...

> +       if (is_of_node(dpmac_node))
> +               fwnode_handle_put(dpmac_node);

> +       if (is_of_node(dpmac_node))
> +               fwnode_handle_put(dpmac_node);

Also not sure that you need a check in the above code excerpts.

-- 
With Best Regards,
Andy Shevchenko