netdev - Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210218081324.GA68220@wp.pl>
Date:   Thu, 18 Feb 2021 09:13:24 +0100
From:   Stanislaw Gruszka <stf_xl@...pl>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables

On Thu, Feb 18, 2021 at 03:20:14PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 28675a4..52db532 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = {
>  	 */
>  	if (ret != IL_INVALID_STATION &&
>  	    (!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) ||
> -	     ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) &&
> -	      (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) {
> +	      (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) {
>  		IL_ERR("Requested station info for sta %d before ready.\n",
>  		       ret);
>  		ret = IL_INVALID_STATION;

This patch was already applied to wireless-drivers-next.

Stanislaw