netdev - Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Feb 2021 18:49:06 +0100
From:   Björn Töpel <bjorn.topel@...el.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     maciej.fijalkowski@...el.com, hawk@...nel.org,
        magnus.karlsson@...el.com, john.fastabend@...il.com,
        kuba@...nel.org, davem@...emloft.net
Subject: Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions

On 2021-02-19 18:10, Toke Høiland-Jørgensen wrote:
>> +	case XDP_REDIR_DEV_MAP: {
>>   		struct bpf_dtab_netdev *dst = fwd;
> I thought the braces around the case body looked a bit odd. I guess
> that's to get a local scope for the dst var (and xs var below), right?
> This is basically a cast, though, so I wonder if you couldn't just as
> well use the fwd pointer directly (with a cast) in the function call
> below? WDYT?

Yeah. I'll fix that in the next verison!


Thanks, and have a nice weekend!
Björn