netdev - Re: [PATCH net 7/8] i40e: Fix add TC filter for IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Feb 2021 18:06:46 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Brelinski, TonyX" <tonyx.brelinski@...el.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Szczurek, GrzegorzX" <grzegorzx.szczurek@...el.com>,
        "Palczewski, Mateusz" <mateusz.palczewski@...el.com>,
        "Gawin, JaroslawX" <jaroslawx.gawin@...el.com>
Subject: Re: [PATCH net 7/8] i40e: Fix add TC filter for IPv6

On Fri, 2021-02-19 at 09:31 -0800, Jakub Kicinski wrote:
> On Thu, 18 Feb 2021 15:25:03 -0800 Tony Nguyen wrote:
> > From: Mateusz Palczewski <mateusz.palczewski@...el.com>
> > 
> > Fix insufficient distinction between IPv4 and IPv6 addresses
> > when creating a filter.
> > IPv4 and IPv6 are kept in the same memory area. If IPv6 is added,
> > then it's caught by IPv4 check, which leads to err -95.
> > 
> > Fixes: 2f4b411a3d67("i40e: Enable cloud filters via tc-flower")
> 
> Small issue with the fixes tag here - missing space after hash.
> 
> Dave said he can't take any patches until Linus gets power back and
> pulls so since we're waiting perhaps you could fix and repost?
> 
> The patches look good to me.

Thanks for the review Jakub. Sure, I'll fix and repost.

- Tony