netdev - Re: [PATCH mellanox-tree] net/mlx5: prevent an integer underflow in mlx5_perout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDH5muwFJB9eyDhL@unreal>
Date:   Sun, 21 Feb 2021 08:11:38 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Saeed Mahameed <saeedm@...dia.com>, Aya Levin <ayal@...dia.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Ariel Levkovich <lariel@...lanox.com>,
        "Pavel Machek (CIP)" <pavel@...x.de>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH mellanox-tree] net/mlx5: prevent an integer underflow in
 mlx5_perout_configure()

On Fri, Feb 19, 2021 at 12:57:52PM +0300, Dan Carpenter wrote:
> The value of "sec" comes from the user.  Negative values will lead to
> shift wrapping inside the perout_conf_real_time() function and triggger
> a UBSan warning.
>
> Add a check and return -EINVAL to prevent that from happening.
>
> Fixes: 432119de33d9 ("net/mlx5: Add cyc2time HW translation mode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Saeed, I think this goes through your git tree and you will send a pull
> request to the networking?
>
> From static analysis.  Not tested.
>
>  drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>