netdev - Re: [PATCH mellanox-tree] net/mlx5: prevent an integer underflow in mlx5_perout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9beab47-4f32-4aa4-cdb6-6fa7402e55de@nvidia.com>
Date:   Mon, 1 Mar 2021 12:12:34 +0200
From:   Eran Ben Elisha <eranbe@...dia.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Saeed Mahameed <saeedm@...dia.com>, Aya Levin <ayal@...dia.com>
CC:     Leon Romanovsky <leon@...nel.org>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Ariel Levkovich <lariel@...lanox.com>,
        "Pavel Machek (CIP)" <pavel@...x.de>, <netdev@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH mellanox-tree] net/mlx5: prevent an integer underflow in
 mlx5_perout_configure()



On 2/19/2021 11:57 AM, Dan Carpenter wrote:
> The value of "sec" comes from the user.  Negative values will lead to
> shift wrapping inside the perout_conf_real_time() function and triggger
> a UBSan warning.
> 
> Add a check and return -EINVAL to prevent that from happening.
> 
> Fixes: 432119de33d9 ("net/mlx5: Add cyc2time HW translation mode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Saeed, I think this goes through your git tree and you will send a pull
> request to the networking?
> 
>  From static analysis.  Not tested.
> 
>   drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
> index b0e129d0f6d8..286824ca62b5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
> @@ -516,7 +516,7 @@ static int mlx5_perout_configure(struct ptp_clock_info *ptp,
>   		nsec = rq->perout.start.nsec;
>   		sec = rq->perout.start.sec;
>   
> -		if (rt_mode && sec > U32_MAX)

This if clause was set to reject perout time start sec bigger than 
U32_MAX, as rt mode specifically doesn't support it.

A user negative values protection should be generic for all netdev 
drivers, inside the caller ioctl func, and not part of any driver code.

> +		if (rt_mode && (sec < 0 || sec > U32_MAX))
>   			return -EINVAL;
>   
>   		time_stamp = rt_mode ? perout_conf_real_time(sec, nsec) :
>