netdev - Re: [PATCH iproute2 v4 1/1] build: Fix link errors on some systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482304af-beef-3703-2309-71e6611acec6@nvidia.com>
Date:   Mon, 22 Feb 2021 12:36:55 +0200
From:   Roi Dayan <roid@...dia.com>
To:     Petr Machata <petrm@...dia.com>
CC:     <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>,
        "Stephen Hemminger" <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 v4 1/1] build: Fix link errors on some systems



On 2021-01-12 2:21 PM, Petr Machata wrote:
> 
> Roi Dayan <roid@...dia.com> writes:
> 
>> Since moving get_rate() and get_size() from tc to lib, on some
>> systems we fail to link because of missing math lib.
>> Move the functions that require math lib to their own c file
>> and add -lm to dcb that now use those functions.
>>
>> ../lib/libutil.a(utils.o): In function `get_rate':
>> utils.c:(.text+0x10dc): undefined reference to `floor'
>> ../lib/libutil.a(utils.o): In function `get_size':
>> utils.c:(.text+0x1394): undefined reference to `floor'
>> ../lib/libutil.a(json_print.o): In function `sprint_size':
>> json_print.c:(.text+0x14c0): undefined reference to `rint'
>> json_print.c:(.text+0x14f4): undefined reference to `rint'
>> json_print.c:(.text+0x157c): undefined reference to `rint'
>>
>> Fixes: f3be0e6366ac ("lib: Move get_rate(), get_rate64() from tc here")
>> Fixes: 44396bdfcc0a ("lib: Move get_size() from tc here")
>> Fixes: adbe5de96662 ("lib: Move sprint_size() from tc here, add print_size()")
>>
>> Signed-off-by: Roi Dayan <roid@...dia.com>
> 
> Looking good:
> 
>      $ ldd ip/ip | grep libm.so
>      $ ldd dcb/dcb | grep libm.so
>              libm.so.6 => /lib64/libm.so.6 (0x00007f204d0c2000)
> 
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Tested-by: Petr Machata <petrm@...dia.com>
> 

Hi,

Pinging about this commit. I noticed it was not taken.
anything you want me to update? push again?

Thanks,
Roi